Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version warning banner for old versions of the docs #531

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

melissawm
Copy link
Member

References and relevant issues

Closes #82

Description

We now get the version warning banner for free so we can turn it on :)

It looks like this currently:

Captura de imagem_20241205_171236

I'm happy to do some CSS styling if we are not happy with how it looks!

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 5, 2024
@DragaDoncila
Copy link
Contributor

I think the version warning banner looks good! I kinda wanna remove the "chat with us" banner though at this point. I don't think it should be a permanent fixture on the website, and seeing the stacked banners now is making my eye twitch lol. I remember some conversation about how we couldn't just 'turn it off'? Is that still true?

@psobolewskiPhD
Copy link
Member

this will also warn when the page is old right? I still hit old tutorials and things via google and image.sc links

@melissawm
Copy link
Member Author

How do we feel about this?

Captura de imagem_20241223_154848

Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@DragaDoncila DragaDoncila added this to the 0.5.6 milestone Dec 26, 2024
@psobolewskiPhD psobolewskiPhD merged commit c61df46 into napari:main Dec 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add warning banner to older versions of documentation
3 participants