-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning banner to older versions of documentation #82
Comments
I think this is a much needed addition! Thanks for creating a separate issue @melissawm It's interesting how the numpy docs only show the banner for versions 1.19 and older. |
@codemonkey800 is this something you might be able to do in the napari-sphinx-theme? |
Following up on this. Here's the current proposal to implement this directly into the pydata-sphinx-theme, and the related discussion We can either wait for this to be implemented in the PyData Sphinx Theme and then cherrypick this into the napari sphinx theme, or echo that implementation in the napari theme right now, updating/removing it as it is merged into the PyData theme later. @codemonkey800 any thoughts? |
I think this is a great idea. When can we do it? |
Hi friends - here is a proof of concept using PyData Sphinx Theme's preliminary implementation: https://melissawm.github.io/napari.github.io/0.4.15/index.html This is just a test, so I haven't enabled the banner in other pages, just the front page (ultimately I don't know that we want to have the warning here, but I just wanted to check that this would work.) A few decisions are pending, for example the design which I'm not looking into at all so far. This change will also involve multiple Pull Requests across the repos (napari/napari.github.io, napari/docs, napari/napari-sphinx-theme) and some manual tweaking of previous versions, which will only need to be done once. Because of this, I will wait for a definitive "go ahead" before doing anything. |
One of the things I really liked about the Sphinx one is that it had a
colored background. I think this really helps draw attention to it. Can
we do one with a colored background? I know we will have to be careful to
keep it accessible for colorblind/sight challenged people but I think the
majority of our users would benefit from it.
…On Fri, Mar 3, 2023 at 9:27 AM Melissa Weber Mendonça < ***@***.***> wrote:
Hi friends - here is a proof of concept using PyData Sphinx Theme's
preliminary implementation:
https://melissawm.github.io/napari.github.io/0.4.15/index.html
https://melissawm.github.io/napari.github.io/0.4.16/index.html
https://melissawm.github.io/napari.github.io/0.4.17/index.html
https://melissawm.github.io/napari.github.io/dev/index.html
This is just a test, so I haven't enabled the banner in other pages, just
the front page (ultimately I don't know that we want to have the warning
here, but I just wanted to check that this would work.)
A few decisions are pending, for example the design which I'm not looking
into at all so far.
This change will also involve multiple Pull Requests across the repos
(napari/napari.github.io, napari/docs, napari/napari-sphinx-theme) and
some manual tweaking of previous versions, which will only need to be done
once. Because of this, I will wait for a definitive "go ahead" before doing
anything.
—
Reply to this email directly, view it on GitHub
<#82 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3CMNTB3NXNB2P5KLZGSNKDW2IEXJANCNFSM6AAAAAATKXFWPA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sure! Like I said, design is still not a focus right now because I want to get a general "ok" first, but we certainly will need to think of that later. |
As we discussed at the meeting, I personally think this would be extremely useful and helpful. It's not hard to find either google links, tutorials, image.sc posts, or zulip posts that link to out-dated docs. |
I think that this would be great! |
Bumping for non-zulipers, @melissawm posted how this could be implemented with links to her fork! Super exciting! |
Bumping this. |
📚 Documentation
From napari/napari#5096 (comment):
The text was updated successfully, but these errors were encountered: