Move images to _static folder #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easier to track changes to images in the future.
github-actions
bot
added
the
documentation
jni
approved these changes
Aug 25, 2024
There was a problem hiding this comment.
thanks @melissawm! I think we probably will want to start using some kind of folder structure in there, but we can think about that later. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Related to napari/napari.github.io#412 and other considerations around artifact size
Description
This PR moves all images to be under _static/images with the rationale that it will potentially be easier to compress/redirect them and keep the artifact size smaller.
If this is not a good idea, I'm happy to close. It just seems better to gather all binaries in the same folder and not have them spread over the repo.