Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar updates #116

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Calendar updates #116

merged 2 commits into from
Jul 12, 2022

Conversation

codemonkey800
Copy link
Collaborator

Implements 2 out of 3 requested changes to the calendar directive from #78:

  • Renames directive to calendar
  • Makes calendar ID a directive option instead of an environment variable
  • Fixes key error with duplicate events

Copy link
Member

@kne42 kne42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codemonkey800 codemonkey800 merged commit d20b56e into main Jul 12, 2022
@codemonkey800 codemonkey800 deleted the jeremy/calendar-updates branch July 12, 2022 14:43
@jni
Copy link
Member

jni commented Jul 15, 2022

❤️‍🔥 ❤️‍🔥 ❤️‍🔥 ❤️‍🔥 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants