Add ci to test all plugins on PR label

.github/workflows/ci.yml

@@ -43,6 +43,7 @@ jobs:
           fail_ci_if_error: true
 
   test_napari:
+    if: ${{ github.event.label.name != 'test-all-plugins' }}
     name: napari tests
     runs-on: ubuntu-latest
     steps:

.github/workflows/test_all_plugins.yml

@@ -2,12 +2,11 @@ name: Test all plugins
 
 on:
   pull_request:
-    types: [ labeled ]
   workflow_dispatch:
 
 jobs:
   get-plugins:
-    if: github.event.label.name == 'test-all-plugins' || github.event_name == 'workflow_dispatch'
+    if: contains(github.event.pull_request.labels.*.name, 'test-all-plugins') || github.event_name == 'workflow_dispatch'
     runs-on: ubuntu-latest
     steps:
       - uses: styfle/cancel-workflow-action@0.9.1
@@ -54,7 +53,7 @@ jobs:
       # but also work in the absence of napari... so probably don't want
       # to add napari to their deps.
       - name: install napari
-        if: matrix.plugin == "RedLionfish" || matrix.plugin == "smo"
+        if: ${{ matrix.plugin == 'RedLionfish' || matrix.plugin == 'smo' }}
         run: mamba install napari
 
       - name: Install ${{ matrix.plugin }} from conda

tests/test_all_plugins.py

@@ -1,13 +1,18 @@
 import os
+import warnings
 from importlib import metadata
 from typing import List
 
 import pytest
 
+from npe2._from_npe1 import _python_name, iter_hookimpls
+from npe2.manifest.utils import SHIM_NAME_PREFIX, import_python_name
+
 PLUGIN = os.getenv("TEST_PACKAGE_NAME")
 if not PLUGIN:
     pytest.skip("skipping plugin specific tests", allow_module_level=True)
 
+
 FORGOT_NAPARI = [
     "vessel-express",
     "RedLionfish",
@@ -33,19 +38,45 @@ def entry_points():
 def test_plugin_has_entry_points(entry_points):
     if PLUGIN not in {"napari-console", "napari-error-reporter"}:
         assert entry_points
-        print("EPs:", entry_points)
+        print("\nEPs:", entry_points)
 
 
 if PLUGIN in FORGOT_NAPARI:
-    m = pytest.mark.xfail(reason="forgot napari in deps", strict=True)
+    depsfail = pytest.mark.xfail(reason="forgot napari in deps", strict=True)
 elif PLUGIN == "napari-omero":
-    m = pytest.mark.xfail(reason="needs conda work", strict=True)
+    depsfail = pytest.mark.xfail(reason="needs conda work", strict=True)
 else:
-    m = lambda f: f  # noqa
+    depsfail = lambda f: f  # noqa
 
 
-@m
+@depsfail
 def test_entry_points_importable(entry_points: List[metadata.EntryPoint]):
     for ep in entry_points:
         if ep.group == "napari.plugin":
             ep.load()
+
+
+@depsfail
+def test_npe1_python_names(entry_points: List[metadata.EntryPoint]):
+    for ep in entry_points:
+        if ep.group == "napari.plugin":
+            for impl in iter_hookimpls(ep.load()):
+                if impl.specname not in (
+                    "napari_provide_sample_data",
+                    "napari_experimental_provide_function",
+                    "napari_experimental_provide_dock_widget",
+                ):
+                    continue
+                print()
+                result = impl.function()
+                if isinstance(result, dict):
+                    result = result.values()
+                elif not isinstance(result, list):
+                    result = [result]
+                for idx, item in enumerate(result):
+                    pyname = _python_name(item, impl.function, idx)
+                    print(pyname)
+                    assert import_python_name(pyname) is not None
+                    if SHIM_NAME_PREFIX in pyname:
+                        warnings.warn("SHIMMING: %r" % pyname)
+                    assert SHIM_NAME_PREFIX not in pyname  # temporary