Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decoding and encoding to string for Graph #5
base: master
Are you sure you want to change the base?
Add decoding and encoding to string for Graph #5
Changes from 2 commits
8d50a64
c69202d
54b5e80
7c0d405
7217223
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this step got left out entirely.
I'm not sure where to fit it now, since I'm assuming we need to do this only after
get_results
, but it doesn't seem correct to never de-allocate the jobThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with a breaking change here, if a new result type needs to be used.
Returning different types based on the result leads to an inconsistent API.
I'd rather return
{:ok, []}
, or even{:ok, %Result{}}
(with a result object that we could later mutate further if needed)`.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another option would be to just add a separate
Graph.get_results(job)
function to retrieve these values afterwards.Might be worth checking how the .NET wrapper does it, since this one was mostly based on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually liked the
get_results
idea, but I still had to change return structure.