Skip to content

project updates#8

Merged
napsy merged 4 commits intonapsy:masterfrom
gucio321:master
May 8, 2025
Merged

project updates#8
napsy merged 4 commits intonapsy:masterfrom
gucio321:master

Conversation

@gucio321
Copy link
Collaborator

@gucio321 gucio321 commented May 8, 2025

Hi!
according to #7 (which is fixed here btw) I did the following changes:

  • corrected a problem with tests which were broken (I suppose since my last PR)
  • unintentionally fixed broken parsing if reading more rules #7 😄 (Turns out that cleaning rule variable after block end did the trick - I added that temporarily for debugging clearity)
  • added GitHub action that runs tests (which is pretty useful imao)

@napsy
Copy link
Owner

napsy commented May 8, 2025

Amazing work! Glad to see this project is of use for someone 👍

Merging

@napsy napsy closed this May 8, 2025
@napsy napsy reopened this May 8, 2025
@napsy napsy merged commit 8278eaa into napsy:master May 8, 2025
@gucio321
Copy link
Collaborator Author

gucio321 commented May 8, 2025

@napsy what do you thing about adding this to awesome-go? there is no other usable css parser imao (one is 11 years old an the other is cgo for some reason)

@napsy
Copy link
Owner

napsy commented May 9, 2025

@gucio321 sure, go ahead and propose the change to add go-css. I fully support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

broken parsing if reading more rules

2 participants