Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add Friend Request feature] make a friend request #440

Closed
linga66 opened this issue Jun 5, 2023 · 5 comments · Fixed by #501
Closed

[Add Friend Request feature] make a friend request #440

linga66 opened this issue Jun 5, 2023 · 5 comments · Fixed by #501
Assignees

Comments

@linga66
Copy link
Contributor

linga66 commented Jun 5, 2023

Description

I want to add a feature called friend request

Go to someone else's profile and make a friend request. Friend request should be given to other people

Assign this issue to me @narayan954
I think i can do this

Screenshots

Screenshot (495)

Additional information

Assign me this issue @nara

@narayan954
Copy link
Owner

Description

I want to add a feature called friend request

Go to someone else's profile and make a friend request. Friend request should be given to other people

Assign this issue to me @narayan954 I think i can do this

Screenshots

Screenshot (495)

Additional information

Assign me this issue @nara

bro I'm not @nara, I'm @narayan954 . Also, this one's a difficult one. Can you please tell your approach?

@linga66
Copy link
Contributor Author

linga66 commented Jun 6, 2023

Sorry 😅
I will Create a APIs to handle friend request-related operations. I will create a backend inserting new friend requests into the FriendRequests table, updating the status of friend requests, and fetching pending friend requests for a user.

@narayan954
Copy link
Owner

Sorry sweat_smile I will Create a APIs to handle friend request-related operations. I will create a backend inserting new friend requests into the FriendRequests table, updating the status of friend requests, and fetching pending friend requests for a user.

Hi, you can directly interact with firebase database , you don't need to create a separate backend for this only. I'd suggest to insert into a new collection 'users' . Users will have user entitites containing several fields which are going to be used in future issues as well. Field we'll be using for this issue could be friendlist/friends and friendRequests both as array. if a user clicks on add friend button, userid would be added to the friendRequests array of the user, which he can accept. About accepting... in profile there could be a section, accept requests where the requests shall be rendered. Finally he accepts/reject it cleaning from friendlist and moving either to friendlist or going void, respectively.... User can also view his friendlist. There are many stuffs to perform for this task so procede in sequence, first just work on till sending a friendrequest... later we can add issue to accept and add to friendlist.

@narayan954
Copy link
Owner

narayan954 commented Jun 6, 2023

@linga66 go through my suggestion above and provide any suggestion/different approach if you want. Just try not to add a separate backend as we don't have one except firebase right now and perhaps won't need one anytime soon.

@narayan954
Copy link
Owner

narayan954 commented Jun 25, 2023

let the pull request close the issue. Im reviewing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants