-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Add friend request button and notification button #501
Conversation
Is everything okay? @narayan954 |
have you tested this?? the code breaks |
Yes.! Everything works good at my side.. do I need to commit again? |
When sending friend request, error happens as seen in firebase(ignore the CORS error) |
Also, there're some merge conflicts, but I can manage them. You can just fix the error :) |
Can you tell me where the error is!? |
you didn't import firebase. follow the implementation of imgupload component. Also, even after sending the friend request, it doesn't show up in other users notification. |
@linga66 the sender and receiver's id is the same as well as it can be seen in the screenshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while resolving conflict, you didn't remove the merge conflict indicators and they're causing syntax errors. Please correct them and check for any syntax error.
Are there any other changes for me to solve? |
I'll review this as soon as I get the time, please wait. |
Is everything okay? |
Is there any problem, why is my pr not being merged? @narayan954 |
Hi @linga66 , actually I'm quite busy right now due to my internship and college training... I'll review it asap. I've added the labels so you can get the points. Did you not get the points? |
No I didn't get any points |
oh ok, I'll merge this asap, your points are safe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok for now, function is lagging some implementation and testing
I've reduced the points as you didn't test anything, and imports were missing/incorrect. |
I explicitly mentioned there you're missing this import , still you didn't fix that |
As mentioned in issue id #440 I have made the changes