Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Add friend request button and notification button #501

Merged
merged 9 commits into from
Jun 25, 2023

Conversation

linga66
Copy link
Contributor

@linga66 linga66 commented Jun 20, 2023

As mentioned in issue id #440 I have made the changes

Screenshot (640)
Screenshot (641)
Screenshot (642)
Screenshot (639)

@linga66 linga66 changed the title Updated viewing our own profile Updated Add friend request button and notification button Jun 20, 2023
@linga66
Copy link
Contributor Author

linga66 commented Jun 20, 2023

Is everything okay? @narayan954

@narayan954
Copy link
Owner

Is everything okay? @narayan954

have you tested this?? the code breaks

@linga66
Copy link
Contributor Author

linga66 commented Jun 20, 2023

Is everything okay? @narayan954

have you tested this?? the code breaks

Yes.! Everything works good at my side.. do I need to commit again?

@narayan954
Copy link
Owner

Is everything okay? @narayan954

have you tested this?? the code breaks

Yes.! Everything works good at my side.. do I need to commit again?

Is everything okay? @narayan954

have you tested this?? the code breaks

Yes.! Everything works good at my side.. do I need to commit again?

When sending friend request, error happens as seen in firebase(ignore the CORS error)
image

@narayan954
Copy link
Owner

narayan954 commented Jun 20, 2023

Also, there're some merge conflicts, but I can manage them. You can just fix the error :)

@linga66
Copy link
Contributor Author

linga66 commented Jun 20, 2023

When sending friend request, error happens as seen in firebase(ignore the CORS error)

Can you tell me where the error is!?
I'm not good at firebase.

@narayan954
Copy link
Owner

When sending friend request, error happens as seen in firebase(ignore the CORS error)

Can you tell me where the error is!?
I'm not good at firebase.

you didn't import firebase. follow the implementation of imgupload component. Also, even after sending the friend request, it doesn't show up in other users notification.

@narayan954
Copy link
Owner

@linga66 the sender and receiver's id is the same as well as it can be seen in the screenshot.
image

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while resolving conflict, you didn't remove the merge conflict indicators and they're causing syntax errors. Please correct them and check for any syntax error.

src/App.jsx Outdated Show resolved Hide resolved
src/pages/Profile/index.jsx Outdated Show resolved Hide resolved
src/pages/Profile/index.jsx Outdated Show resolved Hide resolved
@linga66
Copy link
Contributor Author

linga66 commented Jun 22, 2023

Are there any other changes for me to solve?

@narayan954
Copy link
Owner

Are there any other changes for me to solve?

I'll review this as soon as I get the time, please wait.

@linga66
Copy link
Contributor Author

linga66 commented Jun 23, 2023

Is everything okay?

@linga66
Copy link
Contributor Author

linga66 commented Jun 24, 2023

Is there any problem, why is my pr not being merged? @narayan954

@narayan954
Copy link
Owner

Is there any problem, why is my pr not being merged? @narayan954

Hi @linga66 , actually I'm quite busy right now due to my internship and college training... I'll review it asap. I've added the labels so you can get the points. Did you not get the points?

@linga66
Copy link
Contributor Author

linga66 commented Jun 24, 2023

No I didn't get any points

@narayan954
Copy link
Owner

No I didn't get any points

oh ok, I'll merge this asap, your points are safe

@narayan954 narayan954 linked an issue Jun 25, 2023 that may be closed by this pull request
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok for now, function is lagging some implementation and testing

@narayan954 narayan954 added level2 and removed level3 labels Jun 25, 2023
@narayan954 narayan954 merged commit c05ed7a into narayan954:master Jun 25, 2023
@narayan954
Copy link
Owner

I've reduced the points as you didn't test anything, and imports were missing/incorrect.

@narayan954
Copy link
Owner

narayan954 commented Jun 25, 2023

When sending friend request, error happens as seen in firebase(ignore the CORS error)

Can you tell me where the error is!?
I'm not good at firebase.

you didn't import firebase. follow the implementation of imgupload component. Also, even after sending the friend request, it doesn't show up in other users notification.

I explicitly mentioned there you're missing this import , still you didn't fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Add Friend Request feature] make a friend request
2 participants