Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sticky navbar issue #181

Closed
wants to merge 11 commits into from
Closed

Sticky navbar issue #181

wants to merge 11 commits into from

Conversation

Sar-thak-3
Copy link

@Sar-thak-3 Sar-thak-3 commented Feb 19, 2023 •
edited
Loading

#179 issue

narayan954 and others added 5 commits February 4, 2023 20:04
@narayan954
changed deployment to firebase
e41ccf2
@narayan954
Update package-lock.json
3498c67
@narayan954
Squashed commit of the following:
d660d7a 
commit 0517aaf
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Wed Feb 15 00:59:45 2023 +0530

    Update package-lock.json

commit 4b57c30
Merge: ee7a41a bbdc4cd
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Wed Feb 15 00:55:56 2023 +0530

    Merge branch 'master' of https://github.com/narayan954/dummygram

commit ee7a41a
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Wed Feb 15 00:55:30 2023 +0530

    update dependencies using ncu

commit bbdc4cd
Merge: 93a7f0b 29f1472
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Wed Feb 15 00:50:23 2023 +0530

    Merge pull request narayan954#162 from narayan954/deepsource-transform-749baf1a

commit 29f1472
Author: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Date:   Tue Feb 14 19:18:36 2023 +0000

    Format code with prettier

    This commit fixes the style issues introduced in 93a7f0b according to the output
    from prettier.

    Details: https://deepsource.io/gh/narayan954/dummygram/transform/3d05dcf5-af9b-44e2-bdc0-6f568250e0db/

commit 93a7f0b
Merge: 0711181 a531d72
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Wed Feb 15 00:48:24 2023 +0530

    Merge pull request narayan954#159 from TheXro/darkmode

    fixed: Post background changes color on switching to dark mode narayan954#118

commit 0711181
Merge: 247a1da 9e1abd2
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Wed Feb 15 00:31:53 2023 +0530

    Merge pull request narayan954#161 from A91y/master

    Updated CONTRIBUTING.md and README.md

commit 9e1abd2
Author: A91y <ayush.agr254@gmail.com>
Date:   Wed Feb 15 00:22:15 2023 +0530

    Updated CONTRIBUTING.md and README.md

commit a531d72
Author: TheXro <ravyyadav97@gmail.com>
Date:   Tue Feb 14 21:24:01 2023 +0530

    fixed issue narayan954#118

commit 247a1da
Merge: f3214fb fcd0865
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Tue Feb 14 01:32:25 2023 +0530

    Merge pull request narayan954#157 from narayan954/deepsource-transform-015baf48

commit fcd0865
Author: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Date:   Mon Feb 13 20:00:26 2023 +0000

    Format code with prettier

    This commit fixes the style issues introduced in f3214fb according to the output
    from prettier.

    Details: https://deepsource.io/gh/narayan954/dummygram/transform/014a0045-5ff3-455b-a465-ae9e4d965d28/

commit f3214fb
Merge: ab136eb 533cdbe
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Tue Feb 14 01:30:13 2023 +0530

    Merge pull request narayan954#156 from TheXro/TheXro

    fixed: fix white space on mobile view and z axis of theme switcher narayan954#146

commit 533cdbe
Author: TheXro <ravyyadav97@gmail.com>
Date:   Mon Feb 13 19:08:40 2023 +0530

    fixed issue narayan954#146

commit ab136eb
Merge: b4939e4 5485504
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Sun Feb 5 18:13:01 2023 +0530

    Merge pull request narayan954#139 from narayan954/deepsource-fix-9bbfc17a

    Remove `true` from boolean attribute

commit 5485504
Merge: 9331c9b 63dd7f1
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Sat Dec 24 23:07:28 2022 +0530

    Merge branch 'master' into deepsource-fix-9bbfc17a

commit 9331c9b
Author: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Date:   Tue Dec 20 16:43:32 2022 +0000

    Remove `true` from boolean attribute
@narayan954
Merge branch 'master'
124b78b
@Sar-thak-3
Merge branch 'main' of https://github.com/narayan954/dummygram
7579a0d
github-actions[bot]
github-actions bot reviewed Feb 19, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

narayan954
narayan954 requested changes Feb 20, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove unnecessary changes in package.json and vite configuration. merge with the master branch

@narayan954
Copy link
Owner

The problem was , you merged the main branch with the master, which was running separate. Reverting that commit fixed it.

@Sar-thak-3
Copy link
Author

The problem was , you merged the main branch with the master, which was running separate. Reverting that commit fixed it.

Is it fine now, or I need to make any other changes?

narayan954
narayan954 requested changes Feb 20, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fill in some margin between the post and navbar like old view

@narayan954
Copy link
Owner

@Sar-thak-3 you can follow the comment :)

narayan954
narayan954 requested changes Feb 20, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! these changes are breaking the layout in mobile view, can you try fixing that?
breaking responsivenes

@Sar-thak-3
Copy link
Author

Hi there! these changes are breaking the layout in mobile view, can you try fixing that? breaking responsivenes

image
In my system it's working fine, kindly check it

@narayan954
Copy link
Owner

Okay I understand, but can you give it more margin, like in the original case. That way it looks nice.
And also, can you fix the issue 2 as mentioned in the image below
sticky navbar

thanks

@narayan954 narayan954 marked this pull request as draft February 22, 2023 19:38
@narayan954
Copy link
Owner

closing as inactive and no response

@narayan954 narayan954 closed this Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@narayan954 narayan954 narayan954 requested changes

Assignees
No one assigned
Labels
no-issue-activity
Projects
Dummygram
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sar-thak-3 @narayan954