-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #262 Added Password Hide and Show option #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Hi @sayedulkrm, It disappears after we have interacted with buttons but appears every first interaction, which is not good. |
@narayan954 Hi there. I don't know how you get this bug. As you can see here are no such things. Please review the code once again |
Please don't comment the code here, I can see the code at files changed section or my local setup. |
issue.mp4 |
could it be browser specific? update: Yes, it's browser specific, but can we make it uniform for all browsers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Merging it keeping the issue to be handled in mind. |
Sorry that I post the code here. |
It's okay, keep it up! |
All codes remain the same. I just added Hide and show function.