Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #262 Added Password Hide and Show option #263

Merged
merged 2 commits into from
May 15, 2023
Merged

issue #262 Added Password Hide and Show option #263

merged 2 commits into from
May 15, 2023

Conversation

sayedulkrm
Copy link
Contributor

All codes remain the same. I just added Hide and show function.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

Copy link
Contributor Author

@sayedulkrm sayedulkrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@narayan954
Copy link
Owner

Thank you

Hi @sayedulkrm,
There's a bug in signup page where we're getting default show button as well. Can you please fix that?
image

It disappears after we have interacted with buttons but appears every first interaction, which is not good.
Please try to fix that.
Thank you.

@sayedulkrm
Copy link
Contributor Author

sayedulkrm commented May 15, 2023

Thank you

Hi @sayedulkrm, There's a bug in signup page where we're getting default show button as well. Can you please fix that? image

It disappears after we have interacted with buttons but appears every first interaction, which is not good. Please try to fix that. Thank you.

@narayan954 Hi there. I don't know how you get this bug.
aaaa

As you can see here are no such things. Please review the code once again

@narayan954
Copy link
Owner

Please don't comment the code here, I can see the code at files changed section or my local setup.
To regenerate the issue I am facing, go directly from log in to sign up and start typing some characters in the password box, you should be able to notice the issue.
I'll look and review the code again as well.
Thank you :)

@narayan954
Copy link
Owner

issue.mp4

@narayan954
Copy link
Owner

narayan954 commented May 15, 2023

could it be browser specific?
let's check that

update: Yes, it's browser specific, but can we make it uniform for all browsers?

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@narayan954
Copy link
Owner

Merging it keeping the issue to be handled in mind.
Thanks a lot for your contribution @sayedulkrm

@narayan954 narayan954 merged commit 2e58890 into narayan954:master May 15, 2023
@narayan954 narayan954 linked an issue May 15, 2023 that may be closed by this pull request
@sayedulkrm
Copy link
Contributor Author

Sorry that I post the code here.
Thank You so much for accepting. 👍🏻 👍🏻

@narayan954
Copy link
Owner

Sorry that I post the code here. Thank You so much for accepting. 👍🏻 👍🏻

It's okay, keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Password Hide and show function.
2 participants