Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overflow of Caption fixed with added new class and by defining it in … #291

Merged
merged 5 commits into from
May 23, 2023
Merged

Overflow of Caption fixed with added new class and by defining it in … #291

merged 5 commits into from
May 23, 2023

Conversation

Shubham185y
Copy link
Contributor

@Shubham185y Shubham185y commented May 22, 2023 •
edited
Loading

#273 of Caption fixed with added new class and by defining it in css file as well
Before:
image

After:
image

github-actions[bot]
github-actions bot reviewed May 22, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

@Shubham185y Shubham185y mentioned this pull request May 22, 2023
Closed
narayan954
narayan954 requested changes May 22, 2023
View reviewed changes
src/components/Post.jsx Show resolved Hide resolved
src/components/Post.jsx Outdated Show resolved Hide resolved
src/index.css Outdated Show resolved Hide resolved
@Shubham185y
Copy link
Contributor Author

image
responsive as well:
image

narayan954
narayan954 approved these changes May 23, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 4048e40 into narayan954:master May 23, 2023
@narayan954
Copy link
Owner

Thanks for your contribution :)

@narayan954 narayan954 linked an issue May 23, 2023 that may be closed by this pull request
Bug Text overflow which is given in caption #273
Closed
@narayan954 narayan954 mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
codepeak level1
Projects
Dummygram
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Text overflow which is given in caption
2 participants
@Shubham185y @narayan954