-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm password field in signup page #336 #365
Conversation
@narayan954 please have a look I made the proposed changes |
why have you created a separate branch and new pr, you should've just updated that pr :/ |
I am beginner to open source I try to update same branch with creating another PR but fail to do it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small change
That's where you should ask, if you don't try, how'd you learn? I commented on that pull request to the problem you'll be facing. You needed to force push the branch. It's similar to the command you use to push, you just have to add -f to the command. For example |
@narayan954 I made the changes please have a look |
Sure, on it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Thanks for your contribution! :) |
solves #336