Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm password field in signup page #336 #365

Merged
merged 4 commits into from
May 27, 2023
Merged

Confirm password field in signup page #336 #365

merged 4 commits into from
May 27, 2023

Conversation

shraddha761
Copy link
Contributor

@shraddha761 shraddha761 commented May 27, 2023

solves #336

@shraddha761
Copy link
Contributor Author

@narayan954 please have a look I made the proposed changes

@narayan954
Copy link
Owner

@narayan954 please have a look I made the proposed changes

why have you created a separate branch and new pr, you should've just updated that pr :/

@shraddha761
Copy link
Contributor Author

I am beginner to open source I try to update same branch with creating another PR but fail to do it

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change

src/pages/Signup.jsx Outdated Show resolved Hide resolved
src/pages/Signup.jsx Outdated Show resolved Hide resolved
@narayan954
Copy link
Owner

I am beginner to open source I try to update same branch with creating another PR but fail to do it

That's where you should ask, if you don't try, how'd you learn? I commented on that pull request to the problem you'll be facing. You needed to force push the branch. It's similar to the command you use to push, you just have to add -f to the command. For example git push -f instead of git push

@shraddha761
Copy link
Contributor Author

@narayan954 I made the changes please have a look

@narayan954
Copy link
Owner

@narayan954 I made the changes please have a look

Sure, on it!

@narayan954 narayan954 linked an issue May 27, 2023 that may be closed by this pull request
@narayan954 narayan954 changed the title Changes were made Confirm password field in signup page #336 May 27, 2023
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit c2e5e5a into narayan954:master May 27, 2023
@narayan954
Copy link
Owner

Thanks for your contribution! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Confirm password field in signup page
2 participants