Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edit profile pic feature added #406

Merged
merged 3 commits into from
Jun 1, 2023
Merged

edit profile pic feature added #406

merged 3 commits into from
Jun 1, 2023

Conversation

SasiVardhan247
Copy link
Contributor

Solved issues in pr #394. @narayansoni can you review the changes

@narayan954 narayan954 linked an issue May 31, 2023 that may be closed by this pull request
Adding Profile pic #364
Closed
narayan954
narayan954 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 37d53ea into narayan954:master Jun 1, 2023
@narayan954
Copy link
Owner

Hi @SasiVardhan247 thanks for contribution but I wanted to remind you one thing you missed. You don't have to work on the master branch, create a separate branch for the changes. Keep the master branch clean so you can safely pull changes from the remote branch.For now, you can clean fetch your master branch from this remote by force pull.

@narayan954
Copy link
Owner

Also, there's no progress indication of profile pic upload. You can implement one like in the upload post.

@SasiVardhan247
Copy link
Contributor Author

Hi @SasiVardhan247 thanks for contribution but I wanted to remind you one thing you missed. You don't have to work on the master branch, create a separate branch for the changes. Keep the master branch clean so you can safely pull changes from the remote branch.For now, you can clean fetch your master branch from this remote by force pull.

ok sure , nxt time i'll work on seperate branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
codepeak level2
Projects
Dummygram
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding Profile pic
2 participants
@SasiVardhan247 @narayan954