-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dark mode feature #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)
Hello there @Kritika30032002, can you please use react packages (like react-dark-mode-toggle ) for dark mode instead? It'd be better for the project. |
Also, the toggle button is overlapping with the scroll to top button's affected area and hence sometimes we're clicking on scroll to top button instead of toggle dark mode. |
Okay |
Okay |
@narayan954 I am not much familiar with react though I tried but not able to do this through react package. If you can accept this PR then I will remove the overlapping of the toggle button and scroll to top button. You can let me know your decision. |
okay fine , you can go ahead. |
Okay |
@narayan954 its done! |
okay thanks! will take a look asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for your contribution :) |
issue #31
Added Dark Mode Feature with dark mode toggle button and dark Mode effects to the website.