Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dark mode feature #85

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Added dark mode feature #85

merged 3 commits into from
Oct 21, 2022

Conversation

Kritika30032002
Copy link
Contributor

issue #31

Added Dark Mode Feature with dark mode toggle button and dark Mode effects to the website.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

@narayan954
Copy link
Owner

Hello there @Kritika30032002, can you please use react packages (like react-dark-mode-toggle ) for dark mode instead? It'd be better for the project.
Thanks.

@narayan954
Copy link
Owner

Also, the toggle button is overlapping with the scroll to top button's affected area and hence sometimes we're clicking on scroll to top button instead of toggle dark mode.

@Kritika30032002
Copy link
Contributor Author

Hello there @Kritika30032002, can you please use react packages (like react-dark-mode-toggle ) for dark mode instead? It'd be better for the project. Thanks.

Okay

@Kritika30032002
Copy link
Contributor Author

Also, the toggle button is overlapping with the scroll to top button's affected area and hence sometimes we're clicking on scroll to top button instead of toggle dark mode.

Okay

@Kritika30032002
Copy link
Contributor Author

Hello there @Kritika30032002, can you please use react packages (like react-dark-mode-toggle ) for dark mode instead? It'd be better for the project. Thanks.

@narayan954 I am not much familiar with react though I tried but not able to do this through react package.

If you can accept this PR then I will remove the overlapping of the toggle button and scroll to top button. You can let me know your decision.

@narayan954
Copy link
Owner

Hello there @Kritika30032002, can you please use react packages (like react-dark-mode-toggle ) for dark mode instead? It'd be better for the project. Thanks.

@narayan954 I am not much familiar with react though I tried but not able to do this through react package.

If you can accept this PR then I will remove the overlapping of the toggle button and scroll to top button. You can let me know your decision.

okay fine , you can go ahead.

@Kritika30032002
Copy link
Contributor Author

Hello there @Kritika30032002, can you please use react packages (like react-dark-mode-toggle ) for dark mode instead? It'd be better for the project. Thanks.

@narayan954 I am not much familiar with react though I tried but not able to do this through react package.
If you can accept this PR then I will remove the overlapping of the toggle button and scroll to top button. You can let me know your decision.

okay fine , you can go ahead.

Okay

@Kritika30032002
Copy link
Contributor Author

@narayan954 its done!
You can have a look to it!

@narayan954
Copy link
Owner

@narayan954 its done!
You can have a look to it!

okay thanks! will take a look asap

@Kritika30032002
Copy link
Contributor Author

@narayan954

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@narayan954 narayan954 merged commit 20cf6cf into narayan954:master Oct 21, 2022
@narayan954
Copy link
Owner

Thanks for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants