refactor(classes): use cached length for loops

nartc · Jul 8, 2021 · 21435b7 · 21435b7
1 parent 697ee81
commit 21435b7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/classes/src/lib/storages/class-metadata.storage.ts b/packages/classes/src/lib/storages/class-metadata.storage.ts
@@ -26,7 +26,11 @@ export class ClassMetadataStorage implements MetadataStorage<Constructible> {
     }
 
     const resultMetadataList: Array<Metadata<Constructible>> = [];
-    for (let i = 0; i < metadataList.length; i++) {
+    for (
+      let i = 0, metadataListLen = metadataList.length;
+      i < metadataListLen;
+      i++
+    ) {
       const metadata = metadataList[i];
       // skip existing
       if (

diff --git a/packages/classes/src/lib/utils/instantiate.util.ts b/packages/classes/src/lib/utils/instantiate.util.ts
@@ -40,8 +40,7 @@ export function instantiate<TModel extends Dictionary<TModel>>(
   // initialize a nestedConstructible with empty []
   const nestedConstructible: unknown[] = [];
 
-  // reversed loop
-  for (let i = 0; i < metadata.length; i++) {
+  for (let i = 0, metadataLen = metadata.length; i < metadataLen; i++) {
     // destructure
     const [key, meta, isGetterOnly] = metadata[i];