fix(core): adjust isDefined

nartc · Jan 3, 2021 · 6187453 · 6187453
1 parent c0a406d
commit 6187453
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/packages/classes/src/lib/utils/instantiate.util.ts b/packages/classes/src/lib/utils/instantiate.util.ts
@@ -49,7 +49,7 @@ export function instantiate<TModel extends Dictionary<TModel>>(
 
     // if is String, Number, Boolean, assign valueAtKey or undefined
     if (isPrimitiveConstructor(metaResult)) {
-      instance[key] = isDefined(valueAtKey) ? valueAtKey : undefined;
+      instance[key] = isDefined(valueAtKey, true) ? valueAtKey : undefined;
       continue;
     }
 

diff --git a/packages/core/src/lib/utils/is-defined.util.ts b/packages/core/src/lib/utils/is-defined.util.ts
@@ -1,3 +1,3 @@
-export function isDefined(value: unknown): boolean {
-  return value != null;
+export function isDefined(value: unknown, strict = false): boolean {
+  return strict ? value !== undefined : value != null;
 }
diff --git a/packages/core/src/lib/utils/specs/is-defined.spec.ts b/packages/core/src/lib/utils/specs/is-defined.spec.ts
@@ -3,6 +3,7 @@ import { isDefined } from '@automapper/core';
 describe('isDefined', () => {
   it('should return properly', () => {
     expect(isDefined(null)).toEqual(false);
+    expect(isDefined(null, true)).toEqual(true);
     expect(isDefined(undefined)).toEqual(false);
     expect(isDefined('foo')).toEqual(true);
     expect(isDefined(String)).toEqual(true);