-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: enable uv cache, use astral-sh official action #956
ci: enable uv cache, use astral-sh official action #956
Conversation
This is how Shall we trigger CI rerun and see if it cuts the |
I re-triggered for python 3.12 here |
did it work? shall we ship it? |
I honestly could not spot much of the difference, but still would prefer to use the official action rather then a manual installation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree - let's do this then, thanks @aidoskanapyanov !
Wow that some graph! Thanks for taking such an in depth look at this! I guess that uv is faster than building, checking and grabbing from a cache then π Should we revert this one? |
Yeah, I think we need to revert it, installing from |
Could also be that we've added 3 new dev dependencies since then |
What type of PR is this? (check all applicable)
Related issues
astral-sh/setup-uv@v2
github action and enable caching in the CIΒ #955Checklist
If you have comments or can explain your changes, please do so below.
Also added
cache-dependency-glob
pattern to revalidate the cache whenever therequirements-dev.txt
file is changed. I hope this will work, gotta test it :)