Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change local search engine installation. #18

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

ronitagarwala01
Copy link
Contributor

@ronitagarwala01 ronitagarwala01 commented Nov 21, 2023

Change local search engine from ElasticSearch to OpenSearch. Note that OpenSearch's security plugin is disabled during local development.

Fixes #16.

Change from Elastic Search to Open Search.
@ronitagarwala01 ronitagarwala01 changed the title Change local search server installation. Change local search engine installation. Nov 21, 2023
Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed the command-line flag -Expack.security.enabled=false and added a YAML configuration file. Is that command-line flag not supported in OpenSearch?

@ronitagarwala01
Copy link
Contributor Author

No that specific command is not supported in opensearch. Also I didn't add the yaml file, it comes with the local installation of opensearch. I just wrote to it to disable the security plugin.

@lpsinger
Copy link
Member

Right, but you can control this setting from the command line using -Eplugins.security.disabled. Please pass the configuration variables on the command line. Let's not modify any of the files from the OpenSearch distribution if we can avoid it.

@ronitagarwala01
Copy link
Contributor Author

Ok I just removed it.

@lpsinger
Copy link
Member

Yes, but you need to add it to the command line arguments.

@ronitagarwala01
Copy link
Contributor Author

You're right. Just fixed.

@lpsinger lpsinger merged commit 8442cb9 into nasa-gcn:main Nov 21, 2023
lpsinger added a commit to lpsinger/architect-plugin-search that referenced this pull request Nov 26, 2023
In nasa-gcn#18, we switched from using OpenSearch instead of Elastic for
local sandbox mode. Update links in the README accordingly.
lpsinger added a commit that referenced this pull request Nov 26, 2023
In #18, we switched from using OpenSearch instead of Elastic for
local sandbox mode. Update links in the README accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from elastic search implementation to open search
2 participants