Add batch indexing #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpsinger
requested changes
Nov 21, 2023
ronitagarwala01
force-pushed
the
batchIndex
branch
from
e21517c to
b0ea9ac
Compare
|
Just wanted to add another comment about batch size. It MUST be even. Because of how client.bulk() works, each entry in the data array is mapped to two consecutive objects: One that has the index and id to store the data entry at, and the second that has the actual data. Using an odd batch size would separate these into different batches likely causing it to not work properly. |
lpsinger
requested changes
Nov 21, 2023
ronitagarwala01
force-pushed
the
batchIndex
branch
2 times, most recently
from
ad2ac94 to
6ea6661
Compare
Helps reduce single request load and avoids timeout errors from JS client
-Switch to Array.forEach method for faster indexing -Use lodash chunk method for batching
Import only chunk from lodash Co-authored-by: Leo Singer <leo.p.singer@nasa.gov>
lpsinger
requested changes
Nov 22, 2023
ronitagarwala01
force-pushed
the
batchIndex
branch
from
6ea6661 to
773cfe3
Compare
lpsinger
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps reduce single request load and avoids timeout errors from JS client