Fall back to Docker for sandbox mode (Docker CLI version) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made this a draft because in Remix projects the container is left running after killing the Remix dev server. |
|
I think that the reason that the container is getting orphaned is remix-run/remix#6871. The remix dev server kills Architect, and there is no opportunity to gracefully stop the Docker container. |
lpsinger
force-pushed
the
docker
branch
2 times, most recently
from
40b4815
to
2fc9f42
Compare
lpsinger
changed the title
|
Closing in favor of #30. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSearch isn't yet built for macOS (see opensearch-project/opensearch-build#38), the platform that half of our developers use. Fall back to Docker for sandbox mode if Elasticsearch or OpenSearch is not built for the user's platform.
Note: merge #26 first.