Refactor optimistic locking loop into an abstract base class #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 91.66% 92.59% +0.92%
==========================================
Files 1 1
Lines 24 27 +3
Branches 3 3
==========================================
+ Hits 22 25 +3
Misses 1 1
Partials 1 1
☔ View full report in Codecov by Sentry. |
This makes it easier to create different autoincrement variations with the same optimistic locking loop (e.g. nasa-gcn#20).
lpsinger
force-pushed
the
refactor-optimistic-locking-loop
branch
from
a2e8e62 to
5f14e31
Compare
|
Rebased now. |
dakota002
approved these changes
Oct 31, 2023
Oh, I see. It has been for a while. I'll make another PR to fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to create different autoincrement variations with the same optimistic locking loop (e.g. #20).
Note: this is a smaller diff than it may look at first; most of the lines hit are due to changing the level of indentation. Suppress whitespace changes when reading the diff.