SWIFT UVOT + General SWIFT Notices Binary Conversions #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit int conversion removed MAXI_UNKNOWN conversion Removed GECAM_FLT and GECAM_GND conversion Added documentation and changed function name reformatted file deleted files
athish-thiru
force-pushed
the
swift_uvot
branch
from
92efa8c to
ff4afa4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 75.94% 84.66% +8.71%
==========================================
Files 10 21 +11
Lines 158 300 +142
==========================================
+ Hits 120 254 +134
- Misses 38 46 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Added instrument modes SWIFT UVOT binary conversion small changes more small changes
athish-thiru
force-pushed
the
swift_uvot
branch
from
ff4afa4 to
8659795
Compare
bob-wiegand
reviewed
Jan 23, 2025
| "fits_file_url": f"http://gcn.gsfc.nasa.gov/gcn/notices_s/{utils.binary_to_string(bin[22:39])}", | ||
| "pixel_binning": pixel_binning_values[pixel_binning[0]], | ||
| "bright_star_nearby": bool(misc_bits[13]), | ||
| "originally_subtresh": bool(misc_bits[20]), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the general SWIFT notices sent by all the instruments as well as all the notices sent by SWIFT UVOT. While skimming through the packet socket documentation, I noticed that SWIFT_UVOT_NACK_POS was a notice that continues to be produced but was not present in the repo. Added the following keywords not present in the core-schema:
SWIFT_ACTUAL_POINTDIR
SWIFT_POINTDIR
SWIFT_FOM_OBS, SWIFT_TOO_FOM
SWIFT_SC_SLEW, SWIFT_TOO_SC_SLEW
SWIFT_UVOT_DBURST, SWIFT_UVOT_DBURST_PROC
SWIFT_UVOT_FCHART, SWIFT_UVOT_FCHART_PROC
SWIFT_UVOT_POS