Update to Remix 1.19.0 #1131
Merged
Update to Remix 1.19.0 #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Closed
|
Remix 1.19.0 is out! This is now ready for review. |
dakota002
approved these changes
Jul 19, 2023
lpsinger
added a commit
to lpsinger/gcn.nasa.gov
that referenced
this pull request
Jul 19, 2023
Fixes the following ESLint warning that was revealed by nasa-gcn#1131: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-duplicates.md
lpsinger
added a commit
to lpsinger/gcn.nasa.gov
that referenced
this pull request
Jul 19, 2023
Fix the following eslint warnings revealed by nasa-gcn#1131: ``` app/components/NestedCheckboxes.tsx 69:7 warning Elements with the ARIA role "treeitem" must have the following attributes defined: aria-selected jsx-a11y/role-has-required-aria-props 111:15 warning Elements with the ARIA role "treeitem" must have the following attributes defined: aria-selected jsx-a11y/role-has-required-aria-props ```
lpsinger
force-pushed
the
remix-1.19.0
branch
2 times, most recently
from
4fb7d33 to
220bb3c
Compare
Courey
approved these changes
Jul 19, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1131 +/- ##
========================================
- Coverage 5.83% 5.74% -0.10%
========================================
Files 95 95
Lines 2209 2244 +35
Branches 270 273 +3
========================================
Hits 129 129
- Misses 2078 2113 +35
Partials 2 2
☔ View full report in Codecov by Sentry. |
lpsinger
added a commit
to lpsinger/gcn.nasa.gov
that referenced
this pull request
Jul 19, 2023
I failed to update this when rebasing nasa-gcn#1131.
lpsinger
added a commit
that referenced
this pull request
Jul 19, 2023
I failed to update this when rebasing #1131.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remix 1.19.0 is in pre-releases right now, but the DX is so much nicer that folks might want to try it early!