Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add titles to all pages #475

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Add titles to all pages #475

merged 1 commit into from
Dec 14, 2022

Conversation

lpsinger
Copy link
Member

Titles are now specified hierarchically; each page exports a "breadcrumb" and the title is constructed from the concatenation of the page's breadcrumb and the breadcrumbs of all of its ancestors.

Note: in the future, we will be able to specify breadcrumbs in Markdown frontmatter. See remix-run/remix#4865.

Titles are now specified hierarchically; each page exports a
"breadcrumb" and the title is constructed from the concatenation
of the page's breadcrumb and the breadcrumbs of all of its
ancestors.

Note: in the future, we will be able to specify breadcrumbs in
Markdown frontmatter. See remix-run/remix#4865.
@lpsinger lpsinger added the frontend Issue relates to front-end development (react-uswds widgets) label Dec 14, 2022
@lpsinger lpsinger requested a review from dakota002 December 14, 2022 20:31
@dakota002 dakota002 merged commit 0ff8609 into nasa-gcn:main Dec 14, 2022
@lpsinger lpsinger deleted the titles branch December 14, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issue relates to front-end development (react-uswds widgets)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants