Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to schema, don't bundle it #795

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

lpsinger
Copy link
Member

This way, it is always up to date.

Fixes nasa-gcn/gcn-schema#49.

This way, it is always up to date.

Fixes nasa-gcn/gcn-schema#49.
@lpsinger lpsinger requested a review from dakota002 April 13, 2023 12:53
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (3706ecc) 4.56% compared to head (a8b7cca) 4.59%.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #795      +/-   ##
========================================
+ Coverage   4.56%   4.59%   +0.03%     
========================================
  Files         75      75              
  Lines       1775    1762      -13     
  Branches     211     207       -4     
========================================
  Hits          81      81              
+ Misses      1694    1681      -13     
Impacted Files Coverage Δ
app/routes/schema/$.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dakota002 dakota002 merged commit dfa4d89 into nasa-gcn:main Apr 13, 2023
@lpsinger lpsinger deleted the schema-redirect branch April 13, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to schema doesn't exist
2 participants