Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some bugs in GCN Circulars subject placeholder #796

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Fix some bugs in GCN Circulars subject placeholder #796

merged 1 commit into from
Apr 13, 2023

Conversation

lpsinger
Copy link
Member

  • Fix off-by-one error in month
  • Fix day-of-month (was set to day-of-week)
  • Move long expressions out of template string to improve code readability

@lpsinger
Fix some bugs in GCN Circulars subject placeholder
c6eac64 
- Fix off-by-one error in month
- Fix day-of-month (was set to day-of-week)
- Move long expressions out of template string to improve code
  readability
@lpsinger lpsinger added the frontend Issue relates to front-end development (react-uswds widgets) label Apr 13, 2023
@lpsinger lpsinger added this to the GCN Circulars modernization milestone Apr 13, 2023
@lpsinger lpsinger requested a review from dakota002 April 13, 2023 14:40
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (dfa4d89) 4.86% compared to head (c6eac64) 4.86%.

Additional details and impacted files 
@@           Coverage Diff            @@
##            main    #796      +/-   ##
========================================
- Coverage   4.86%   4.86%   -0.01%     
========================================
  Files         75      75              
  Lines       1766    1769       +3     
  Branches     207     207              
========================================
  Hits          86      86              
- Misses      1680    1683       +3
Impacted Files Coverage Δ
app/routes/circulars/new.tsx 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lpsinger lpsinger merged commit ac71839 into nasa-gcn:main Apr 13, 2023
@lpsinger lpsinger deleted the circulars-subject-placeholder-bugfix branch April 13, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakota002 dakota002 dakota002 approved these changes

Assignees
No one assigned
Labels
frontend Issue relates to front-end development (react-uswds widgets)
Projects
None yet
Milestone
GCN Circulars modernization
Development

Successfully merging this pull request may close these issues.
2 participants
@lpsinger @dakota002