Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WV-3299 View Dates queries DescribeDomains for ongoing layers #5554

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

PatchesMaps
Copy link
Contributor

Description

For ongoing layers, include "View Dates" option that queries DescribeDomains

How To Test

  1. git checkout WV-3299-view-dates
  2. npm i && npm run watch
  3. Navigate to this url
  4. Click the info button and "View Dates" for each respective layer.
  5. A loading spinner should display for a short period for the TEMPO layer while it requests the DescribeDomains data.
  6. Verify the DescribeDomains request in the network panel if you wish.

PR Submission Checklist

This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been merged and published in downstream modules (if applicable)

Merging

Please use the squash and merge commit method unless each commit in your branch is vital to the commit history of main.

@nasa-gibs/worldview

@minniewong
Copy link
Contributor

minniewong commented Nov 7, 2024

Should we also be doing something similar for layers of other temporal ranges e.g. a 4-day product or 8-day product. This fix doesn't seem to cover those use cases

Screenshot 2024-11-07 at 12 53 11 PM

@minniewong minniewong added this to the v4.51.0 milestone Nov 7, 2024
@PatchesMaps
Copy link
Contributor Author

This will work for any layer that has a DescribeDomains response (which should be all of them?), we just need to remove the restrictions.

web/js/workers/dd.worker.js Outdated Show resolved Hide resolved
@PatchesMaps PatchesMaps merged commit 9a00d84 into develop Nov 12, 2024
4 checks passed
@minniewong minniewong modified the milestones: v4.51.0, v4.52.0 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants