WV-3395 Prevent Tour Text Box From Resetting Scroll During Animation #5605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christof-wittreich
requested review from
PatchesMaps,
minniewong and
Tomcariello
Tomcariello
approved these changes
Dec 12, 2024
minniewong
approved these changes
Dec 16, 2024
christof-wittreich
added a commit
that referenced
this pull request
Dec 17, 2024
* dependency updates (#5604) * Change TEMPO from Beta to Provisional (#5594) * Dependency Updates 12-13-24 (#5616) * WV-3399: Remove wrap PACE orbit and update outdated links (#5606) * Update OrbitTracks_PACE_Descending.json * update outdated links * Removed scrolling to top on update (#5605) * v4.54.0 --------- Co-authored-by: Patrick Moulden <4834892+PatchesMaps@users.noreply.github.com> Co-authored-by: minniewong <min.m.wong@nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change prevents the scroll position of the text box during a tour story from being reset to the top during every animation step while an animation is playing.
How To Test
git checkout wv-3395-animation-text-scrollnpm cinpm run watch