Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WV-3397 Issue with changing color palettes for dual color paletted layer #5636

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

PatchesMaps
Copy link
Contributor

Description

Dual color paletted layers like IMERG Precipitation Rate has an issue when changing the color palette of the second color bar (Snow Rate), and it changes the palette of the first tab, Rain Rate.

How To Test

  1. git checkout WV-3397-changing-palettes
  2. npm i && npm run watch
  3. Go to this link
  4. Change the Rain Rate palette to "Red 2" and then change the Snow Rate palette to "Blue 1"
  5. The palettes should apply appropriately

PR Submission Checklist

This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been merged and published in downstream modules (if applicable)

Merging

Please use the squash and merge commit method unless each commit in your branch is vital to the commit history of main.

@nasa-gibs/worldview

@minniewong minniewong added this to the v4.55.0 milestone Dec 27, 2024
@christof-wittreich
Copy link
Contributor

This seems to fix it perfectly fine, but I wonder if using a uuid is necessary here. Don't we have enough information to create a unique key for each using the currently used id field, alongside the index field from props?

@PatchesMaps
Copy link
Contributor Author

@christof-wittreich yeah, that works too, index should prevent any collisions

@PatchesMaps PatchesMaps merged commit 4986a39 into develop Jan 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants