-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename actuator classes #87
Conversation
With this merge complete, I'll mint |
@alex-brinkman, we might still want to make it a major release since, even not modifying |
So prior to v1.0.0, I'm falling back to this rule: I've found that as soon as we mint v1.0.0 after a big development thrust, we tend to need to jump to v2.0.0 or even v3.0.0 really quickly, so I'd prefer to let the dust settle on these change for a few months and target the v1.0.0 release for this summer, aligning with other application schedules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the comments in the Egd
's documentation and minor details I pointed out, my only major observation is that we are allowing the use of Actuator
in bus topologies even though we need to update bus topologies right now because of the renaming of egd_
* parameters. I think it would be simpler to update everything at the same time.
As for the naming, I don't remember what was the consensus for the name of the base class, wasn't it ActuatorBase
or something along those lines? I don't have a preference on this one, but I was left wondering.
Hehe, we should be in this rule indefinitely. My comment stem from here. |
I'd rather not have the |
If a topology contains
|
The internet does not show consensus here so let's leave it to reduce code change. |
Renames:
EgdActuator
->GoldActuator
EpdActuator
->PlatinumActuator
to promote readability after consensus was reached by the development team.
Also Update the Documentation for each of these devices.
I've added
Actuator
class parsing support to backwards compatibility until we release v1.0.0 eventually.