Fix correct signal update #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-brinkman
suggested changes
Apr 10, 2023
src/fastcat_devices/fts.cc
Outdated
| ERROR("Could not extract signal"); | ||
| return false; | ||
| } | ||
| MSG_DEBUG("Signal number %d is value %f", i, signal.value); |
There was a problem hiding this comment.
This will hurt performance and not be helpful long-term when debugging full applications.
There was a problem hiding this comment.
Yes, my bad! Mostly was using this for my own purposes and thought I removed them. I will do that now. :)
alex-brinkman
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through the code, we surmised that calibration matrices with number of signals greater than 6 was not supported. Though the documentation (the previous state of the README), coincides with this, Fts should allow for more than 6 input signals.
These changes give a test that show that with a varying 7th signal, updates are now properly reflected by the UpdateSignals function.