Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making the CRC size configurable #15

Open
skliper opened this issue Apr 22, 2022 · 0 comments
Open

Consider making the CRC size configurable #15

skliper opened this issue Apr 22, 2022 · 0 comments
Labels
enhancement

Comments

@skliper
Copy link
Contributor

skliper commented Apr 22, 2022

There are two CRC algorithm types specified in the platform config. Are both of these using 32-bit CRC? What if we add another CRC algo later that isn't 32-bit? It might make sense to define the type that holds a CRC result in platform config as well.

Comment is on the CS_ComputeEepromMemory function regarding the uint32 ComputedCSValue parameter.

Imported from GSFCCFS-1326
skliper added a commit to skliper/CS that referenced this issue Sep 9, 2022
@skliper
Fix nasa#15, Remove redundant condition in SC_UpdateNextTime for full…
c1938d5 
… coverage
skliper pushed a commit to skliper/CS that referenced this issue Sep 9, 2022
@dzbaker
Merge pull request nasa#37 from skliper/fix21-coverage_test
e484dc0 
Fix nasa#15 nasa#21 nasa#36, Code coverage improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skliper