-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Superfluous assignments, side-effects. type updates etc. #84
Labels
Comments
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
Describe the bug
Some issues that can be easily cleaned up to improve readability and ease maintenance by simplifying the code.
size_t
,CFE_MSG_FcnCode_t
)Code snips
Can be
size_t
:CS/fsw/inc/cs_tbldefs.h
Line 370 in bd4dd1c
Can be
CFE_MSG_FcnCode_t
:CS/fsw/src/cs_app.c
Line 268 in bd4dd1c
Several functions with multiple CS calls that could be made clearer and more compliant with an additional Status/Result variable. e.g.:
CS/fsw/src/cs_app_cmds.c
Lines 215 to 241 in bd4dd1c
Expected behavior
Clear up where it makes sense.
Reporter Info
Avi Weiss @thnkslprpt
The text was updated successfully, but these errors were encountered: