New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #109, Simplify `CS_RecomputeBaselineMemoryCmd` by initializing `State` to `CS_STATE_UNDEFINED` #110

Open

thnkslprpt wants to merge 1 commit into nasa:main from thnkslprpt:fix-109-simplify-CS_RecomputeBaselineMemoryCmd

Contributor

thnkslprpt commented Nov 30, 2024

Checklist

I reviewed the Contributing Guide.
I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.

Describe the contribution

Fixes CS_RecomputeBaselineMemoryCmd can be simplified by initializing State to CS_STATE_UNDEFINED #109
- Initialize State to CS_STATE_UNDEFINED instead of CS_STATE_EMPTY to avoid the need for an additional conditional block before the CS_RECOMPUTE_INVALID_ENTRY_MEMORY_ERR_EID event is sent

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

Expected behavior changes
Function is simplified slightly.

System(s) tested on
Debian 12 using the current main branch of cFS bundle.

Contributor Info
Avi Weiss @thnkslprpt


          Fix nasa#109, Simplify CS_RecomputeBaselineMemoryCmd by initializin…

b691e57

…g `State`

to `CS_STATE_UNDEFINED`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet