Fix #111, CS_Enable/Disable/Get_EntryID
functions clean-up
#112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes CS_Enable/Disable/Get EntryID functions clean-up #111
CS_EnableEntryIDMemoryCmd
ResultsEntry
State
variable used by mistake inCS_ENABLE_MEMORY_DEF_EMPTY_DBG_EID
eventState
can be initialized toCS_STATE_UNDEFINED
instead ofCS_STATE_EMPTY
which simplifies theif
/else
block before theCS_ENABLE_MEMORY_INVALID_ENTRY_ERR_EID
eventCS_DisableEntryIDMemoryCmd
ResultsEntry
State
variable used by mistake inCS_DISABLE_MEMORY_DEF_EMPTY_DBG_EID
eventState
can be initialized toCS_STATE_UNDEFINED
instead ofCS_STATE_EMPTY
which simplifies theif
/else
block before theCS_DISABLE_MEMORY_INVALID_ENTRY_ERR_EID
eventCS_GetEntryIDMemoryCmd
ResultsEntry
andStartOfResultsTable
Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
Functions are simplified without extraneous intermediate variables, and easier to test.
System(s) tested on
Debian 12 using the current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt