Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #111, CS_Enable/Disable/Get_EntryID functions clean-up #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

  • Fixes CS_Enable/Disable/Get EntryID functions clean-up #111

    CS_EnableEntryIDMemoryCmd

    • remove unessesary variable ResultsEntry
    • local State variable used by mistake in CS_ENABLE_MEMORY_DEF_EMPTY_DBG_EID event
    • State can be initialized to CS_STATE_UNDEFINED instead of CS_STATE_EMPTY which simplifies the if/else block before the CS_ENABLE_MEMORY_INVALID_ENTRY_ERR_EID event

    CS_DisableEntryIDMemoryCmd

    • remove unnecessary variable ResultsEntry
    • local State variable used by mistake in CS_DISABLE_MEMORY_DEF_EMPTY_DBG_EID event
    • State can be initialized to CS_STATE_UNDEFINED instead of CS_STATE_EMPTY which simplifies the if/else block before the CS_DISABLE_MEMORY_INVALID_ENTRY_ERR_EID event

    CS_GetEntryIDMemoryCmd

    • remove unnecessary variables ResultsEntry and StartOfResultsTable

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

Expected behavior changes
Functions are simplified without extraneous intermediate variables, and easier to test.

System(s) tested on
Debian 12 using the current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-111-CS_Enable-Disable-Get-EntryID-clean-up branch from b67b0b9 to 0b9cf99 Compare November 30, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CS_Enable/Disable/Get EntryID functions clean-up
1 participant