Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistently named ECI macros #3

Closed
SpaceSteve121 opened this issue Mar 26, 2019 · 0 comments
Closed

Inconsistently named ECI macros #3

SpaceSteve121 opened this issue Mar 26, 2019 · 0 comments
Assignees
@SpaceSteve121

Comments

@SpaceSteve121
Copy link
Contributor

Some macros ECI defines do not follow the naming convention (starting with ECI_) and should be standardized.

Known offenders are the Event types (which start with EVENT_MESSAGE) and HK and Table-related MIDs (which start with SIL_).
@SpaceSteve121 SpaceSteve121 self-assigned this Mar 26, 2019
SpaceSteve121 added a commit that referenced this issue Mar 26, 2019
@SpaceSteve121
Renamed macros to standardize naming (see issue #3)
2fbc239
SpaceSteve121 added a commit that referenced this issue Jul 24, 2019
@SpaceSteve121
Initial Commit
259f1a4 
* Initial baseline for ECI code

Changes from repo start:
* Add Travis CI pipeline to run unit tests and verify example apps build
* Added checksum to event msgs
* Updated macro names to remove last traces of SIL naming convention
* Renamed macros to standardize naming (see issue #3)
* Updated documentation to add into on getting started using examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SpaceSteve121 SpaceSteve121

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SpaceSteve121