Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split header files into external and internal components #101

Open
3 tasks done
jphickey opened this issue Apr 24, 2023 · 0 comments
Open
3 tasks done

Split header files into external and internal components #101

jphickey opened this issue Apr 24, 2023 · 0 comments
Assignees

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Configuration and header files for this app currently have mixed scope - some items apply globally (mission) and some only affect the internal app behavior.

Describe the solution you'd like
Split headers into single scope, so they contain only public/global items (i.e. those that affect CMD/TLM/Table definitions) or they contain private/internal items. The latter would be things that are only used within the local application code and do not affect the interface.

Additional context
Similar to nasa/HS#84. This helps stabilize the interface, so configuration items that do change the interface are clearly marked in a separate file and the user is more aware of the impact the changes will have. It's also important for EDS, where some of these files are generated - keeping a single scope allows for simple source selection vs. #ifdefs.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Apr 24, 2023
jphickey added a commit to jphickey/FM that referenced this issue Apr 28, 2023
Use the "generate_config_includefile" for all headers that can come from
alternate source (e.g. generated or mission-supplied).
jphickey added a commit to jphickey/FM that referenced this issue Apr 28, 2023
Use the "generate_config_includefile" for all headers that can come from
alternate source (e.g. generated or mission-supplied).
jphickey added a commit to jphickey/FM that referenced this issue Apr 28, 2023
Use the "generate_config_includefile" for all headers that can come from
alternate source (e.g. generated or mission-supplied).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant