-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Superfluous assignments at the top of functions #84
Labels
Comments
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
Describe the bug
FM has a many extraneous assignments at the top of functions that are immediately (or definitely before first use) reassigned a value - many to
CFE_SUCCESS
as in nasa/HS#10, but also other to0
,OS_SUCCESS
etc.Code snips
FM/fsw/src/fm_child.c
Lines 61 to 65 in 5c9d4e8
FM/fsw/src/fm_child.c
Lines 1270 to 1273 in 5c9d4e8
FM/fsw/src/fm_cmd_utils.c
Lines 535 to 537 in 5c9d4e8
FM/fsw/src/fm_cmds.c
Lines 75 to 78 in 5c9d4e8
Expected behavior
Remove/combine assignments - unnecessary code.
Reporter Info
Avi Weiss @thnkslprpt
The text was updated successfully, but these errors were encountered: