Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #126, Standardize command responses #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

  • Fixes Standardization of Command Responses #126
    • Adds checks if already in the commanded state (where it makes sense - for example, not for resetting the command counters or for the NOOP)
    • Issues an event string to that effect informing the user that we are already in the commanded state (but still reuses the same EID)
    • Adds 6 new tests for the new logic
    • couple of unrelated typos etc. fixed as well

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
New tests added for added functionality.

Expected behavior changes
HS command responses will now align fully with expectations, and will inform the user if the software is already in the commanded state (and not set it again unnessesarily).

System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

@dzbaker
Copy link
Contributor

dzbaker commented Oct 24, 2024

@thnkslprpt Would you be able to resolve the merge conflicts in this PR and remove the changes to the superfluous comments (in hs_verify.h)?

@thnkslprpt thnkslprpt force-pushed the fix-126-standardize-command-responses branch from b736284 to 9b06fa7 Compare October 24, 2024 19:15
@thnkslprpt thnkslprpt force-pushed the fix-126-standardize-command-responses branch from 9b06fa7 to 21b2a48 Compare October 24, 2024 19:19
@thnkslprpt
Copy link
Contributor Author

@thnkslprpt Would you be able to resolve the merge conflicts in this PR and remove the changes to the superfluous comments (in hs_verify.h)?

@dzbaker that's updated now mate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardization of Command Responses
2 participants