You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However this is not anywhere for any purpose. It may be a remnant that was never cleaned up.
As a result, its using several kB of stack space unnecessarily.
Expected behavior
Should not allocate objects that are not necessary.
System observed on:
Debian
Additional context
This was discovered by analyzing the stack usage and finding that MD sometimes overran its allocated stack. Although there were other issues as well (see nasa/osal#1429) ... it was noted that this unneeded object was a significant contributor for why the problem showed up in MD and not other apps.
Reporter Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered:
jphickey
added a commit
to jphickey/MD
that referenced
this issue
Dec 1, 2023
Remove the Initial dwell table object from MD_InitTableServices.
This object was not actually used, and consumed several kB of
stack space unnecessarily, depending on the size of the table.
Remove the Initial dwell table object from MD_InitTableServices.
This object was not actually used, and consumed several kB of
stack space unnecessarily, depending on the size of the table.
Checklist (Please check before submitting)
Describe the bug
During init, the MD app instantiates a dwell table on the stack, and memset's it to 0:
MD/fsw/src/md_app.c
Line 331 in b0ae64d
However this is not anywhere for any purpose. It may be a remnant that was never cleaned up.
As a result, its using several kB of stack space unnecessarily.
Expected behavior
Should not allocate objects that are not necessary.
System observed on:
Debian
Additional context
This was discovered by analyzing the stack usage and finding that MD sometimes overran its allocated stack. Although there were other issues as well (see nasa/osal#1429) ... it was noted that this unneeded object was a significant contributor for why the problem showed up in MD and not other apps.
Reporter Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: