Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python data types to the data_handling module #111

Closed
wants to merge 1 commit into from
Closed

Add Python data types to the data_handling module #111

wants to merge 1 commit into from

Conversation

dragonejt
Copy link
Contributor

Changes

  • Add Python data types to each function definition in the data_handling module
  • Working towards Add Python Data Types to functions #109
  • Used Instagram/MonkeyType to run driver.py and get some working function definitions with types, and tried to fill in the rest based off of what was returned by those functions. Please make sure that the function parameter and return types are actually correct
  • Decided to stick with first-level types e.g. list instead of list[float] as some types are deeply nested, complicated multilevel types
  • Added .vscode/ (VSCode configurations folder) to .gitignore

Testing

  • python driver.py -t succeeded
  • python driver.py did not return any errors

@the-other-james
Copy link
Contributor

Hi @dragonejt, thanks for putting in this PR. I will take a look at this soon (currently pushing for a critical deadline). I agree that adding data types can help folks understand the code faster and I want to learn more about how they work in Python.

Thanks!

@dragonejt dragonejt closed this by deleting the head repository Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants