Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

82 add reporter plugins #121

Merged
merged 5 commits into from
Mar 22, 2024
Merged

82 add reporter plugins #121

merged 5 commits into from
Mar 22, 2024

Conversation

asgibson
Copy link
Contributor

Added a reporter plugin that can be used multiple times to output information. An example of using reporters can be run with onair/config/reporter_config.ini. It is defaulted to non verbose mode just to show update and rendering flow, but changing the verbose_mode attribute to default to True in the Reporter's Plugin class will change that to outputting low and high level data.

@asgibson asgibson added the enhancement New feature or request label Feb 23, 2024
@asgibson asgibson self-assigned this Feb 23, 2024
@asgibson asgibson linked an issue Feb 23, 2024 that may be closed by this pull request
@asgibson
Copy link
Contributor Author

Please note this is dependent upon #119

Reporters will state who they are and what method is running
  also outputs the arguments, their types, and values
Added reporter_config.ini that uses one of each kind in the config dicts
agent.py
  removed some trailing whitespaces
reporters
  fixed naming of AIPlugin to match new usage
Now that multiple use of same plugin can be done, only 1 reporter class required
Now reports out via its name
Reports function and data, low and high
  update reports data it was given and records it
  render_reasoning reports known data
Added VERBOSITY constant for easy on/off of data reporting
  when True, all outputs
  when False, reporter only states function
Reporter Plugin
  changed VERBOSE to verbose_mode attribute
  update
    moved setting of values to outside of verbose_mode printing
Test
  full coverage testing for both functions in verbose and not verbose
Copy link
Contributor

@the-other-james the-other-james left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Runs as expected on my system.

Thanks!

@asgibson asgibson merged commit bda906b into main Mar 22, 2024
2 checks passed
@asgibson asgibson deleted the 82-add-reporter-plugins branch March 22, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reporter plugins
2 participants