Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

120 update flow through ai constructs #122

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

asgibson
Copy link
Contributor

Updates to system flow

Learners

  • now accept high level data

Planners

  • now call update on all existing planner constructs on interface update
  • now call render_reasoning on all planner constructs on interface render_reasoning

Complex

  • added update_and_render_reasoning function
    -- updates and renders reasoning on each reasoning construct before the next
    -- passes results of previous complex reasoners to subsequent complex reasoners
  • removed update and render_reason functions from interface which were no longer used

Agent

  • removed render_reasoning
    -- it was only called locally and is no longer used
    -- it only rendered the complex and that responsibility is now in the complex interface
  • new flow of data through ai constructs
    -- vehicle rep updates every knowledge construct with frame (low_level_data)
    -- aggregate_high_level_data adds the vehicle reps knowledge construct results (vehicle state information)
    -- learning systems all update with frame (low_level_data, vehicle curr data) and aggregate high_level_data
    -- aggregate_high_level_data adds the learning systems construct results
    -- planning systems all update with aggregate high_level_data
    -- aggregate_high_level_data adds the planning systems construct results
    -- complex reasoners update and render reasoning (passing results down to each in the interface) with the final result being returned by the agent

@asgibson asgibson added enhancement New feature or request convention Repository coding and documentation standards labels Feb 23, 2024
@asgibson asgibson self-assigned this Feb 23, 2024
@asgibson asgibson linked an issue Feb 23, 2024 that may be closed by this pull request
@asgibson asgibson force-pushed the 120-update-flow-through-ai-constructs branch from ab03fde to b0c3757 Compare March 13, 2024 20:44
@asgibson asgibson linked an issue Mar 13, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (16230e6) to head (f931d95).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        26    +1     
  Lines          951       970   +19     
  Branches       133       136    +3     
=========================================
+ Hits           951       970   +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Lerners
  now accept high level data
Planners
  now call update on all existing planner constructs on interface update
  now call render_reasoning on all planner constructs on interface render_reasoning
Complex
  added update_and_render_reasoning function
    updates and renders reasoning on each reasoning construct before the next
    passes results of previous complex reasoners to subsequent complex reasoners
  removed update and render_reason functions from interface which were no longer used
Agent
  removed render_reasoning
    it was only called locally and is no longer used
    it only rendered the complex and that responsibility is now in the complex interface
  new flow of data through ai constructs
    vehicle rep updates every knowledge construct with frame (low_level_data)
    aggregate_high_level_data adds the vehicle reps knowledge construct results (vehicle state information)
    learning systems all update with frame (low_level_data, vehicle curr data) and aggregate high_level_data
    aggregate_high_level_data adds the learning systems construct results
    planning systems all update with aggregate high_level_data
    aggregate_high_level_data adds the planning systems construct results
    complex reasoners update and render reasoning (passing results down to each in the interface) with the final result being returned by the agent
The use of `|=` is only available since Python 3.9
Reverting to `update` for more backward compatibility
@asgibson asgibson force-pushed the 120-update-flow-through-ai-constructs branch from f931d95 to d54b117 Compare March 22, 2024 17:31
Copy link
Contributor

@the-other-james the-other-james left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I love having the reporter plugin! Ran as expected on my system.

@asgibson asgibson merged commit 16fe993 into main Mar 22, 2024
2 checks passed
@asgibson asgibson deleted the 120-update-flow-through-ai-constructs branch March 22, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
convention Repository coding and documentation standards enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update flow through AI constructs Planners plugin doesn't update?
3 participants