-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
120 update flow through ai constructs #122
Conversation
ab03fde
to
b0c3757
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 26 +1
Lines 951 970 +19
Branches 133 136 +3
=========================================
+ Hits 951 970 +19 ☔ View full report in Codecov by Sentry. |
Lerners now accept high level data Planners now call update on all existing planner constructs on interface update now call render_reasoning on all planner constructs on interface render_reasoning Complex added update_and_render_reasoning function updates and renders reasoning on each reasoning construct before the next passes results of previous complex reasoners to subsequent complex reasoners removed update and render_reason functions from interface which were no longer used Agent removed render_reasoning it was only called locally and is no longer used it only rendered the complex and that responsibility is now in the complex interface new flow of data through ai constructs vehicle rep updates every knowledge construct with frame (low_level_data) aggregate_high_level_data adds the vehicle reps knowledge construct results (vehicle state information) learning systems all update with frame (low_level_data, vehicle curr data) and aggregate high_level_data aggregate_high_level_data adds the learning systems construct results planning systems all update with aggregate high_level_data aggregate_high_level_data adds the planning systems construct results complex reasoners update and render reasoning (passing results down to each in the interface) with the final result being returned by the agent
The use of `|=` is only available since Python 3.9 Reverting to `update` for more backward compatibility
f931d95
to
d54b117
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I love having the reporter plugin! Ran as expected on my system.
Updates to system flow
Learners
Planners
Complex
-- updates and renders reasoning on each reasoning construct before the next
-- passes results of previous complex reasoners to subsequent complex reasoners
Agent
-- it was only called locally and is no longer used
-- it only rendered the complex and that responsibility is now in the complex interface
-- vehicle rep updates every knowledge construct with frame (low_level_data)
-- aggregate_high_level_data adds the vehicle reps knowledge construct results (vehicle state information)
-- learning systems all update with frame (low_level_data, vehicle curr data) and aggregate high_level_data
-- aggregate_high_level_data adds the learning systems construct results
-- planning systems all update with aggregate high_level_data
-- aggregate_high_level_data adds the planning systems construct results
-- complex reasoners update and render reasoning (passing results down to each in the interface) with the final result being returned by the agent