Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

123 replace incomplete environment definition file #124

Merged
merged 7 commits into from
Mar 26, 2024

Conversation

asgibson
Copy link
Contributor

@asgibson asgibson commented Mar 8, 2024

Updated for easier conda usage

  • requirements_pip replaced by environment.yml
  • unit test CI run now uses miniconda
  • new command in README based on changes

@asgibson asgibson added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 8, 2024
@asgibson asgibson self-assigned this Mar 8, 2024
@asgibson asgibson linked an issue Mar 8, 2024 that may be closed by this pull request
@asgibson asgibson force-pushed the 123-replace-incomplete-environment-definition-file branch 3 times, most recently from b06969a to 6995a5a Compare March 15, 2024 17:10
@asgibson asgibson force-pushed the 123-replace-incomplete-environment-definition-file branch from 6995a5a to 67e5344 Compare March 22, 2024 17:31
@asgibson asgibson force-pushed the 123-replace-incomplete-environment-definition-file branch from 67e5344 to 18b56a5 Compare March 22, 2024 18:54
Copy link
Contributor

@the-other-james the-other-james left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I updated the Dockerfile to use miniconda so my flow still works.

@asgibson asgibson merged commit 3b164eb into main Mar 26, 2024
2 checks passed
@asgibson asgibson deleted the 123-replace-incomplete-environment-definition-file branch March 26, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace incomplete environment definition file
3 participants