-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
112 implement multi channel redis #125
Conversation
ef3fc27
to
0891e3c
Compare
b0611c5
to
8858c1c
Compare
Updated CONFIG for use by redis-experiment-publisher shows a simple way to see data move through redis to OnAIR Added custom error to DataSource for key config errors Fixed columnization of redis_adapter Redis adapter now checks multiple channels detects when time is missing from received message helps detect unused keys helps detect missing expected keys warns if listener exits Updated and added necessary unit tests for coverage and code verification
Named generic plugins for redis example Added to README how to run the Redis example Rebased to main
8858c1c
to
f038fee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Runs on my machine, and I tested using your excellent instructions/script to launch the redis publisher.
@@ -14,6 +14,110 @@ Create a conda environment with the necessary packages | |||
|
|||
conda env create -f environment.yml | |||
|
|||
## Redis example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These instructions are great!
We many want to consider moving them to the wiki in order to keep the README shorter.
Multiple channel Redis subscriptions are now allowed.
Example with experimental Redis publisher script included.