126 provide some backwards compatibility with previous python versions #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgibson
added
enhancement
asgibson
force-pushed
the
126-provide-some-backwards-compatibility-with-previous-python-versions
branch
3 times, most recently
from
faeed87
to
897f0fb
Compare
Updated dependencies to allow for 3.9-3.11 Updated dependencies to not require specific versions of other packages Updated unit-test.yml to run under 3.9, 3.10 and 3.11
For unknown reason using 3.9, 3.10, and 3.11 used 3.9, 3.1, and 3.11 3.1 failed because environment.yml only allowed 3.9-3.11 Retrying with just 3.11 to ensure previously working version works with matrix
GitHub warning prompted this change: Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, codecov/codecov-action@v3. Node.js 16 actions are deprecated. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
See if it is still operational with checkout at v4
Previous CI failed correctly, 3.8 not allowed in env
asgibson
force-pushed
the
126-provide-some-backwards-compatibility-with-previous-python-versions
branch
from
897f0fb
to
086ca73
Compare
the-other-james
approved these changes
Apr 9, 2024
asgibson
deleted the
126-provide-some-backwards-compatibility-with-previous-python-versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI runs show unit test compatibility with Python versions 3.8 thru 3.12.
While this does not ensure "production" usage of OnAIR it does show that all the code used is compatible with those versions.
Python 3.7 was found to have many issues with running unit tests.
It is recommended to stop at 3.8 for now because allowing for Python 3.7 would require more time and effort.