re-implement kalman filter with single sliding-window prediction #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved self.frames initialization of inner lists to `__init__`
That allowed update to be simplified
`flotify_unput` added to `update` to transform low_level_data into all floats and make it the frame
`initial_value` in _predict no longer optional
only place calling it always provided value
Tests updated to reflect changes by adding, subtracting, changing
Tests added to ensure coverage where it was lacking
New testing technique:
`super()` calls mockable
obtain the parent class object (this is what `super()` returns already)
patch any calls to it, including `__init__`
Changed docstrings to Numpy format Added print_msg from util for no raise error output Enforced window size > 2, otherise raise error Black and Pylint changes no single quotes for comments or strings use enumerate not range and len
|
I think this branch needs to pull in the latest changes from main (looks like it is 5 commits behind which explains the conflicting files since the black reformatting touched the old kalman plugin). environment_dev.yml should also be updated I would think. |
the-other-james
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue 145 for more details.