2 floatify #3
Merged
2 floatify #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HayleyO
pushed a commit
to HayleyO/OnAIR
that referenced
this pull request
Aug 7, 2024
…le_redis_server_adapter Unit testing 134 create multiple redis server adapter
asgibson
added a commit
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating from internal repo.
Closes #2
Made minor simplification to floatify_input function, created helper for time strings, and moved floatify_input to parser_util. Also there seems to have been non-numeric cases and handling in past but those were removed at some earlier point.
driver.py output is unchanged. Tests have 100% coverage.