Skip to content

Commit

Permalink
Merge pull request #344 from skliper/fix342-uninit_var
Browse files Browse the repository at this point in the history
Fix #342, Resolve uninit var static analysis warning
  • Loading branch information
astrogeco committed May 31, 2022
2 parents 925fb36 + 05af21e commit 832e16d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
2 changes: 2 additions & 0 deletions fsw/pc-linux/src/cfe_psp_start.c
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ int32 CFE_PSP_OS_EventHandler(OS_Event_t event, osal_id_t object_id, void *data)
char taskname[OS_MAX_API_NAME];
cpu_set_t cpuset;

memset(taskname, 0, sizeof(taskname));

switch (event)
{
case OS_EVENT_RESOURCE_ALLOCATED:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ void Test_Nominal(void)
OS_time_t OsTime;
PSP_VxWorks_TimeBaseVal_t VxTime;

memset(&OsTime, 0, sizeof(OsTime));

/* Nominal test with a simple 1:1 ratio */
UT_PSP_TIMEBASE_VXWORKS_TESTCONFIG.PeriodNumerator = 1;
UT_PSP_TIMEBASE_VXWORKS_TESTCONFIG.PeriodDenominator = 1;
Expand All @@ -103,6 +105,8 @@ void Test_Non_Reducible(void)
PSP_VxWorks_TimeBaseVal_t VxTime;
int64 TestTime;

memset(&OsTime, 0, sizeof(OsTime));

/* Use an oddball ratio of of some primes, will not be reducible */
/* Ratio is 43*3 / 53*2 => 129/106 */
/* This translates to about ~1.217ns per tick */
Expand Down Expand Up @@ -136,6 +140,8 @@ void Test_Reducible_1(void)
PSP_VxWorks_TimeBaseVal_t VxTime;
int64 TestTime;

memset(&OsTime, 0, sizeof(OsTime));

/* Test with a ratio that is also 1:1, but can be reduced */
UT_PSP_TIMEBASE_VXWORKS_TESTCONFIG.PeriodNumerator = 1000;
UT_PSP_TIMEBASE_VXWORKS_TESTCONFIG.PeriodDenominator = 1000;
Expand Down Expand Up @@ -164,6 +170,8 @@ void Test_Reducible_2(void)
PSP_VxWorks_TimeBaseVal_t VxTime;
int64 TestTime;

memset(&OsTime, 0, sizeof(OsTime));

/* Test with a ratio that can be reduced */
/* Final reduced ratio should be 12:5 with 100ns OS ticks */
UT_PSP_TIMEBASE_VXWORKS_TESTCONFIG.PeriodNumerator = 84000;
Expand Down

0 comments on commit 832e16d

Please sign in to comment.